linux-kernel - Re: [PATCH] staging: lustre: make functions as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Feb 2014 12:20:50 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	bergwolf@...il.com, andreas.dilger@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: make functions as static

On Wed, Feb 26, 2014 at 06:17:59PM +0900, Daeseok Youn wrote:
> 
> These functions are only referenced in this file scope
> so it can be marked static.
> And remove space between function name and open parenthesis.

If it's on the same line as a "static" change then it's fine, otherwise
it should go in a separate patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/