linux-kernel - Re: [PATCH] staging: lustre: make functions as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140226113138.GP26722@mwanda>
Date:	Wed, 26 Feb 2014 14:31:38 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	DaeSeok Youn <daeseok.youn@...il.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	bergwolf@...il.com, andreas.dilger@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: make functions as static

On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote:
> Actually , I saw some code like this file which is seperate line
> between return value and function name.
> So I didn't make one line of them.
> 
> Ok, I will make another patch after merge this one.

No, you are misunderstanding what I am saying.  Those type of function
declarations are allowed in the kernel so the original code is fine.
What I am saying is this patch is doing two thing but it should be doing
only one thing.

>  @@ -53,8 +53,8 @@ lnd_t the_o2iblnd = {
>  
>  kib_data_t	      kiblnd_data;
>  
> -__u32
> -kiblnd_cksum (void *ptr, int nob)
> +static __u32
> +kiblnd_cksum(void *ptr, int nob)
>  {
>  	char  *c  = ptr;
>  	__u32  sum = 0;

Changing the white space here is OK because it is a minor related
white space change.

> @@ -368,7 +368,7 @@ kiblnd_create_peer(lnet_ni_t *ni, kib_peer_t **peerp, lnet_nid_t nid)
>  }
>  
>  void
> -kiblnd_destroy_peer (kib_peer_t *peer)
> +kiblnd_destroy_peer(kib_peer_t *peer)
> {

This is a random unrelated white space change, so do it in a separate
patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/