linux-kernel - Re: [PATCH] pwm,renesas-tpu: Add dependency on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140226120800.GA28939@ulmo.nvidia.com>
Date:	Wed, 26 Feb 2014 13:08:03 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Richard Weinberger <richard@....at>
Cc:	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm,renesas-tpu: Add dependency on HAS_IOMEM

On Fri, Jan 31, 2014 at 01:45:18PM +0100, Richard Weinberger wrote:
> On archs like S390 or um this driver cannot build nor work.
> Make it depend on HAS_IOMEM to bypass build failures.
> 
> drivers/built-in.o: In function `tpu_probe':
> drivers/pwm/pwm-renesas-tpu.c:421: undefined reference to `devm_ioremap_resource'
> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  drivers/pwm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

In the long run I think it might be better to add a dummy implementation
for devm_ioremap_resource() in order to make it build properly even for
architectures where it isn't implemented.

For now this looks like the best option. Applied, thanks.

Thierry

Content of type "application/pgp-signature" skipped