linux-kernel - Re: [RFC][PATCH] tracing: Warn and notify if tracepoints are not loaded due to module taint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140226111542.15657cd6@gandalf.local.home>
Date:	Wed, 26 Feb 2014 11:15:42 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC][PATCH] tracing: Warn and notify if tracepoints are not
 loaded due to module taint

On Wed, 26 Feb 2014 12:48:12 +0000 (UTC)
Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:

> > How about instead of a WARN, you use a normal KERN_ERR printk(). There's
> > no point to the entire WARN state dump, that's needlessly verbose.
> > 
> > When you have a normal error print you can have as many as are required
> > and put the mod name back in.
> 
> The good old printk KERN_ERR is a very good idea. I agree that WARN() is
> too verbose for our needs here.

Actually, it's not so bad for the WARN() after my last patch to only
allocate (or even process tracepoints) if mod->num_tracepionts is
greater than zero. I didn't realize you were wasting memory for all
modules that were loaded.

My fear with the KERN_ERR is that it wont be noticeable enough. Where
as a stack dump is something that will catch people's attention.

And as Rusty has said, if you are loading a module that is forced, or
something strange, it is broken. The failure of loading the tracepoints
of a module is a bug if the module happens to have tracepoints.

After the MOD_SIG fix, any failure should be a big banner bug. Either
they are using a forced module with tracepoints that should not be
loaded. Or they have tracepoints is a non-GPL module (which is also a
big no-no).

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/