linux-kernel - Re: [PATCH 5/5] x86 kbuild: LLVMLinux: More cc-options added for clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <530D4445.8060304@zytor.com>
Date:	Tue, 25 Feb 2014 17:32:53 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	behanw@...verseincode.com, mmarek@...e.cz, tglx@...utronix.de,
	mingo@...hat.com, x86@...nel.org, sparse@...isli.org
CC:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-sparse@...r.kernel.org, torvalds@...ux-foundation.org,
	dwmw2@...radead.org, pageexec@...email.hu,
	Jan-Simon Möller <dl9pf@....de>,
	Mark Charlebois <charlebm@...il.com>
Subject: Re: [PATCH 5/5] x86 kbuild: LLVMLinux: More cc-options added for
 clang

On 02/25/2014 05:08 PM, behanw@...verseincode.com wrote:
>  
> +# enforce no-sse for clang
> +ifneq ($(COMPILER),clang)
> +        KBUILD_CFLAGS += $(call cc-option,-mno-sse)
> +        KBUILD_CFLAGS += $(call cc-option,-mpreferred-stack-boundary=3)
> +endif
> +

I'm *very* confused.  You're doing ifneq here but you're talking about
it as if you are *adding* them for Clang, also these options are already
added elsewhere (lines 57, 64, 86, 89) so why add them here?

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/