linux-kernel - Re: [PATCH] ktest: Set CLOSE_CONSOLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140226152937.37b5d80e@gandalf.local.home>
Date:	Wed, 26 Feb 2014 15:29:37 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	MUNEDA Takahiro <muneda.takahiro@...fujitsu.com>
Cc:	Satoru Takeuchi <satoru.takeuchi@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

On Tue, 25 Feb 2014 21:21:18 -0500
MUNEDA Takahiro <muneda.takahiro@...fujitsu.com> wrote:

> Hmm, it seems that we need a following patch as well.
> Or, please merge with the orignal patch.

I folded this fix in, here's the final:

>From 62183dcac539a14ed0a820b8392db353d72a7d7e Mon Sep 17 00:00:00 2001
From: Satoru Takeuchi <satoru.takeuchi@...il.com>
Date: Sun, 23 Feb 2014 10:19:28 +0900
Subject: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
in the kvm.conf.

Link: http://lkml.kernel.org/r/8738jatylb.wl%satoru.takeuchi@gmail.com

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@...il.com>
[ Typo fixed by ]
Signed-off-by: MUNEDA Takahiro <muneda.takahiro@...fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
---
 tools/testing/ktest/examples/kvm.conf | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
index 831c7c5..fbc134f 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,6 +10,10 @@ MACHINE = Guest
 # Use virsh to read the serial console of the guest
 CONSOLE =  virsh console ${MACHINE}
 
+# Use SIGKILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+
 #*************************************#
 # This part is the same as test.conf  #
 #*************************************#
-- 
1.8.5.3


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/