linux-kernel - Re: [PATCH] ASoC: io: Clean up snd_soc_codec_set_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140227041140.GC9383@sirena.org.uk>
Date:	Thu, 27 Feb 2014 13:11:40 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	lgirdwood@...il.com, vinod.koul@...el.com, brian.austin@...rus.com,
	Paul.Handrigan@...rus.com, timur@...i.org, mr.swami.reddy@...com,
	vishwas.a.deshpande@...com, fabio.estevam@...escale.com,
	kuninori.morimoto.gx@...esas.com, sachin.kamat@...aro.org,
	Adam.Thomson.Opensource@...semi.com, dgreid@...omium.org,
	abrestic@...omium.org, swarren@...dia.com, shc_work@...l.ru,
	s.trumtrar@...gutronix.de, bardliao@...ltek.com,
	shawn.guo@...aro.org, LW@...O-electronics.de, mpa@...gutronix.de,
	peter.ujfalusi@...com, Andreas.Irestal@...s.com,
	ckeepax@...nsource.wolfsonmicro.com,
	rf@...nsource.wolfsonmicro.com, viresh.kumar@...aro.org,
	axel.lin@...ics.com, alban.bedel@...onic-design.de,
	voice.shen@...el.com, jic23@...nel.org, mahaijuns@...il.com,
	mike.dyer@...soft.co.uk, b42378@...escale.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: io: Clean up snd_soc_codec_set_cache_io()

On Thu, Feb 27, 2014 at 09:37:45AM +0800, Xiubo Li wrote:

> I'm also thinking could we just discard snd_soc_codec_set_cache_io()
> calling from each individual driver to simply the code? And just bind
> it to devm_regmap_init_i2c() and devm_regmap_init_spi()...

> Is there any other limitations for snd_soc_codec_set_cache_io() usage?

That's the goal overall, I'm not sure it's worth going through and
changing the signature of the function and then later going through and
merging it, it's just too much churn.  The main thing we need to do in
order to do that is to make sure nothing is relying on specific
sequencing during startup, probably by providing a way to manually set
the regmap pointer in the main device probe function rather than in the
ASoC one.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)