| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140227081240.GS9195@lee--X1>
Date: Thu, 27 Feb 2014 08:12:40 +0000
From: Lee Jones <lee.jones@...aro.org>
To: Denis Carikli <denis@...rea.com>
Cc: Bryan Wu <cooloney@...il.com>, Jingoo Han <jg1.han@...sung.com>,
Eric Bénard <eric@...rea.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v11] video: backlight: gpio-backlight: Add DT
support.
> Cc: Bryan Wu <cooloney@...il.com>
> Cc: Jingoo Han <jg1.han@...sung.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Eric Bénard <eric@...rea.com>
> Signed-off-by: Denis Carikli <denis@...rea.com>
> ---
> ChangeLog v10->v11:
Wow, that's a lot of fix-ups.
> - Shrinked the Cc list.
It's okay to have a large CC list, but I'd do it manually rather than
adding a line for each in the commit log. This latter method is good
for one or two extra people you wish to add to an individual patch
when sending a patch-set.
> - Fixed the of_match_table warning.
>
> ChangeLog v9->v10:
> - Only the respective maintainers, or people who responded to the patch
> were kept in the Cc.
> - The unnecessary of_match_ptr in of_match_table was removed.
Why was it unnecessary?
> ChangeLog v8->v9:
> - Added Shawn Guo in the Cc list.
> - The default-brightness-level is now a boolean default-on property,
> the gpio is only touched if the gpio-backlight driver instance probes.
> - The code and documentation was updated accordingly.
>
> ChangeLog v7->v8:
> - The default-state was renamed to default-brightness-level.
> - default-brightness-level is now mandatory, like for backlight-pwm,
> That way we avoid having to handle the case where it's not set,
> which means that we would need not to set the gpio, but still
> report a brightness value for sysfs, when not all gpio controllers are
> able to read the gpio value.
> - switched the default-brightness-level to boolean values (0 or 1) instead
> of using strings ("on", "off", "keep").
> - The documentation was updated accordingly.
> - The example in the documentation now uses the dts gpio defines.
> - The "backlight: gpio_backlight: Use a default state enum." patch was then
> dropped, becuase it is not necessary anymore.
>
> ChangeLog v6->v7:
> - removed a compilation warning with the removal of the useless ret declaration.
>
> ChangeLog v5->v6:
> - The default state handling was reworked:
> - it's now called default-state, and looks like the gpio-leds default-state.
> - it now has a "keep" option, like for the gpio-leds.
> - that "keep" option is the default when the default-state property is not set.
> - The documentation was updated accordingly.
>
> ChangeLog v4->v5:
> - The default-brightness property now defaults to 0 in the driver.
> - def_value int becomes a bool.
> - The check for the gpio validity has been reworked.
> ---
> .../bindings/video/backlight/gpio-backlight.txt | 19 +++++++
> drivers/video/backlight/gpio_backlight.c | 60 +++++++++++++++++---
These should really be in a seperate patch.
> 2 files changed, 72 insertions(+), 7 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
>
> diff --git a/Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt b/Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
> new file mode 100644
> index 0000000..a923193
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
> @@ -0,0 +1,19 @@
> +gpio-backlight bindings
> +
> +Required properties:
> + - compatible: "gpio-backlight"
> + - gpios: describes the gpio that is used for enabling/disabling the backlight
> + (see GPIO binding[0] for more details).
The format of the [0] is confusing and it doesn't really add anything
here. If you wish to reverence an external binding document just write
out the path. Failing that [bindings]/gpio/gpio.txt also works.
> +Optional properties:
> + - default-on: enable the backlight at boot.
> +
> +[0]: Documentation/devicetree/bindings/gpio/gpio.txt
> +
> +Example:
> +
> + backlight {
> + compatible = "gpio-backlight";
> + gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
> + default-on;
> + };
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
<snip>
> +static int gpio_backlight_probe_dt(struct platform_device *pdev,
> + struct gpio_backlight *gbl)
> +{
> + struct device_node *np = pdev->dev.of_node;
> + enum of_gpio_flags gpio_flags;
> + bool default_on = false;
There's no need to initialise this.
> + gbl->fbdev = NULL;
This will already be NULL, as you used kzalloc().
> + default_on = of_property_read_bool(np, "default-on");
> +
> + gbl->def_value = default_on;
Why complicate matters?
gbl->def_value = of_property_read_bool(np, "default-on");
> - bl->props.brightness = pdata->def_value;
> + bl->props.brightness = gbl->def_value;
Do you use gbl->def_value again later? If not:
gbl->def_value = = of_property_read_bool(np, "default-on");
#ifdef CONFIG_OF ?
> +static struct of_device_id gpio_backlight_of_match[] = {
> + { .compatible = "gpio-backlight" },
> + { /* sentinel */ }
> +};
> +
#endif ?
> static struct platform_driver gpio_backlight_driver = {
> .driver = {
> .name = "gpio-backlight",
> .owner = THIS_MODULE,
> + .of_match_table = gpio_backlight_of_match,
of_match_ptr() ?
<snip>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists