linux-kernel - [PATCH 05/46] kernel: Include appropriate header file in kernel/signal.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Feb 2014 16:59:07 +0530
From:	Rashika Kheria <rashika.kheria@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Jason Wessel <jason.wessel@...driver.com>,
	Vincent <vincent.stehle@...oste.net>,
	Rashika Kheria <rashika.kheria@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Kees Cook <keescook@...omium.org>, Tejun Heo <tj@...nel.org>,
	Valdis Kletnieks <Valdis.Kletnieks@...edu>,
	Emese Revfy <re.emese@...il.com>,
	Andrey Vagin <avagin@...nvz.org>,
	Jesper Derehag <jderehag@...mail.com>,
	Vineet Gupta <vgupta@...opsys.com>,
	kgdb-bugreport@...ts.sourceforge.net, josh@...htriplett.org
Subject: [PATCH 05/46] kernel: Include appropriate header file in
 kernel/signal.c

Include appropriate header file kernel/debug/kdb/kdb_private.h in
kernel/signal.c because it contains prototype definitions of functions
declared in kernel/signal.c.

Also, include include/linux/kdb.h in
include/linux/kdb_private.h to remove the following errors:
kernel/debug/kdb/kdb_private.h:172:2: error: unknown type name ‘kdb_func_t’
kernel/debug/kdb/kdb_private.h:178:2: error: unknown type name ‘kdb_repeat_t’
kernel/debug/kdb/kdb_private.h:196:5: error: expected ‘)’ before ‘int’
Inclusion of kdb.h is necessary because it typedefs the above keywords.

This eliminates the following warning in kernel/signal.c:
kernel/signal.c:3640:1: warning: no previous prototype for ‘kdb_send_sig_info’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
Reviewed-by: Josh Triplett <josh@...htriplett.org>
---
 kernel/debug/kdb/kdb_private.h |    1 +
 kernel/signal.c                |    1 +
 2 files changed, 2 insertions(+)

diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h
index 7afd3c8..e7f2c35 100644
--- a/kernel/debug/kdb/kdb_private.h
+++ b/kernel/debug/kdb/kdb_private.h
@@ -13,6 +13,7 @@
  */
 
 #include <linux/kgdb.h>
+#include <linux/kdb.h>
 #include "../debug_core.h"
 
 /* Kernel Debugger Command codes.  Must not overlap with error codes. */
diff --git a/kernel/signal.c b/kernel/signal.c
index 52f881d..aa1cc60 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -42,6 +42,7 @@
 #include <asm/siginfo.h>
 #include <asm/cacheflush.h>
 #include "audit.h"	/* audit_signal_info() */
+#include "debug/kdb/kdb_private.h"
 
 /*
  * SLAB caches for signal bits.
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/