linux-kernel - Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10892.1393506444@warthog.procyon.org.uk>
Date:	Thu, 27 Feb 2014 13:07:24 +0000
From:	David Howells <dhowells@...hat.com>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	dhowells@...hat.com, wolfram@...-dreams.de, khali@...ux-fr.org,
	linux-i2c@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

Wolfram Sang <wsa@...-dreams.de> wrote:

> 'flags' are u16 and the whole range is needed -> %04x

Done.  Note that %02x does not preclude more digits, but I guess it's better
to have things line up.

> for the address simply %03x should do.

Done.

> And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or
> %*phD at least?

My problem with that is that it increases the length of the output by 50% and
there's a hard limit on how much output we may produce.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/