linux-kernel - Re: [PATCH 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <530F5599.2060100@epfl.ch>
Date:	Thu, 27 Feb 2014 16:11:21 +0100
From:	Florian Vaussard <florian.vaussard@...l.ch>
To:	Peter Ujfalusi <peter.ujfalusi@...com>,
	Lee Jones <lee.jones@...aro.org>
CC:	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 0/3] mfd: twl6040: Updates for i2s speed and fix for chip
 deadlock

Hi Peter,

On 02/27/2014 02:56 PM, Peter Ujfalusi wrote:
> Hi,
> 
> While looking into a report by Florian Vaussard [1] I have noticed couple of most
> likely unrelated issues:
> - all boards using twl6040 configures the i2c bus to 400KHz while twl6040 is set
>   to 100KHz as default.
> - if I set the audpwron GPIO high [2] in the bootloader the i2c communication towards
>   twl6040 will be broken
> 
> The solution or these are:
> set the twl6040 to i2c fast mode with regmap patch
> Clear the INTID register right after we request the audpwron GPIO and set it to
> low.
> 
> Generated on top of:
> git://git.linaro.org/people/lee.jones/mfd.git for-mfd-next
> 
> Tested on PandaBoard, PandaBoardES, OMAP4-blaze (SDP)
> 
> [1] http://www.spinics.net/lists/arm-kernel/msg310725.html
> [2] Command in u-boot to enable the audpwron on PandaBoards: gpio set 127
> 
> Regards,
> Peter
> ---
> Peter Ujfalusi (3):
>   mfd: twl6040: Select i2c fast mode as default with regmap patch
>   mfd: twl6040: Move register patching earlier in probe
>   mfd: twl6040: Clear the interrupt ID register before requesting IRQ

Patch 3 is making my system to boot normally.

Now, it is hard to devise if this is the root cause of the problem that
I was experiencing, since adding a sleep at the exact same place was
fixing my issue. Your twl6040_reg_read() could have the same effect,
without solving directly the issue.

Anyway, I tested your series on DuoVero.

Tested-by: Florian Vaussard <florian.vaussard@...l.ch>

Regards,
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/