linux-kernel - Re: [PATCH] usb: gadget: return the right length in ffs_epfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140227234523.GB21032@psi-dev26.jf.intel.com>
Date:	Thu, 27 Feb 2014 15:45:24 -0800
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	Michal Nazarewicz <mina86@...a86.com>
Cc:	Chuansheng Liu <chuansheng.liu@...el.com>, balbi@...com,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, david.a.cohen@...el.com,
	jin.can.zhuang@...el.com, yu.y.wang@...el.com
Subject: Re: [PATCH] usb: gadget: return the right length in ffs_epfile_io()

On Thu, Feb 27, 2014 at 01:15:25PM +0100, Michal Nazarewicz wrote:
> On Thu, Feb 27 2014, Chuansheng Liu <chuansheng.liu@...el.com> wrote:
> > When the request length is aligned to maxpacketsize, sometimes
> > the return length ret > the user space requested len.
> >
> > At that time, we will use min_t(size_t, ret, len) to limit the
> > size in case of user data buffer overflow.
> >
> > But we need return the min_t(size_t, ret, len) to tell the user
> > space rightly also.
> >
> > Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> 
> Acked-by: Michal Nazarewicz <mina86@...a86.com>

Reviewed-by: David Cohen <david.a.cohen@...ux.intel.com>

IMHO it makes sense to push this patch to 3.14-rc since it is an
extension of usb gadget's quick_ep_out_aligned_size merged on 3.14-rc1

Br, David Cohen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/