linux-kernel - Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fvn4yskv.wl%kuninori.morimoto.gx@gmail.com>
Date:	Thu, 27 Feb 2014 16:44:08 -0800 (PST)
From:	Kuninori Morimoto <kuninori.morimoto.gx@...il.com>
To:	Zhang Rui <rui.zhang@...el.com>
Cc:	Richard Weinberger <richard@....at>, eduardo.valentin@...com,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	horms@...ge.net.au, laurent.pinchart+renesas@...asonboard.com
Subject: Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM


Hi Zhang

> On Sat, 2014-01-25 at 23:29 +0100, Richard Weinberger wrote:
> > Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST)
> > broke build on archs wihout io memory.
> > 
> > On archs like S390 or um this driver cannot build nor work.
> > Make it depend on HAS_IOMEM to bypass build failures.
> > 
> > drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource'
> > drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource'
> > 
> > Signed-off-by: Richard Weinberger <richard@....at>
> 
> Kuninori,
> 
> are you okay with this patch?
(snip)
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 35c0664..88efa8f 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -136,6 +136,7 @@ config SPEAR_THERMAL
> >  config RCAR_THERMAL
> >  	tristate "Renesas R-Car thermal driver"
> >  	depends on ARCH_SHMOBILE || COMPILE_TEST
> > +	depends on HAS_IO_MEM
> >  	help
> >  	  Enable this to plug the R-Car thermal sensor driver into the Linux
> >  	  thermal framework.

I guess

 - HAS_IO_MEM
 + HAS_IOMEM


${LINUX}/lib/Makefile say

obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/