linux-kernel - Re: [PATCH 1/2] Staging: comedi: addi-data: fix lines that are over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393574639.1751.YahooMailNeo@web164003.mail.gq1.yahoo.com>
Date:	Fri, 28 Feb 2014 00:03:59 -0800 (PST)
From:	Chase Southwood <chase.southwood@...oo.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Chase Southwood <chase.southwoo@...oo.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"abbotti@....co.uk" <abbotti@....co.uk>
Subject: Re: [PATCH 1/2] Staging: comedi: addi-data: fix lines that are over 80 characters

>On Friday, February 28, 2014 1:57 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:

>>On Fri, Feb 28, 2014 at 10:52:32AM +0300, Dan Carpenter wrote:
>>> On Fri, Feb 28, 2014 at 01:31:20AM -0600, Chase Southwood wrote:
>> > hwdrv_apci1564.c had numerous lines over the column limit.  This patch
>> > splits all such lines to bring them in compliance with coding style.
>> > 
>> > Signed-off-by: Chase Southwood <chase.southwoo@...oo.com>
>> > ---
>> >  .../comedi/drivers/addi-data/hwdrv_apci1564.c      | 50 ++++++++++++++++------
>> >  1 file changed, 36 insertions(+), 14 deletions(-)
>> > 
>> > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
>> > index 2b47fa1..77030c5 100644
>> > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
>> > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
>> > @@ -324,11 +324,15 @@ static int i_APCI1564_ConfigTimerCounterWatchdog(struct comedi_device *dev,
>> >              inl(devpriv->i_IobaseAmcc + APCI1564_TIMER +
>> >              APCI1564_TCW_PROG);
>> >          ul_Command1 = ul_Command1 & 0xFFFFF9FEUL;
>> > -        outl(ul_Command1, devpriv->i_IobaseAmcc + APCI1564_TIMER + APCI1564_TCW_PROG);    /* Stop The Timer */
>> > +        /* Stop The Timer */
>> > +        outl(ul_Command1, devpriv->i_IobaseAmcc + APCI1564_TIMER +
>> > +            APCI1564_TCW_PROG);
>> 
>> Just make a helper function so that you can call it like this:
>> 
>> static void outl_1564_timer(struct addi_private *devpriv, unsigned int cmd,
>>                 unsigned int reg)
>> {
>>     outl(cmd, devpriv->i_IobaseAmcc + APCI1564_TIMER, reg);
>                                                        ^^^
>Should be "devpriv->i_IobaseAmcc + APCI1564_TIMER + reg" obviously.
>
>
>regards,
>dan carpenter

You got it, I'll do it this way and resend.

Thanks,
Chase
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/