linux-kernel - Re: [PATCH v3] tty: Set correct tty name in 'active' sysfs attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Feb 2014 15:14:18 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	David Herrmann <dh.herrmann@...il.com>,
	linux-kernel@...r.kernel.org
CC:	Ray Strode <halfline@...il.com>, Werner Fink <werner@...e.de>,
	Peter Hurley <peter@...leysoftware.com>,
	Lennart Poettering <lennart@...ttering.net>,
	Kay Sievers <kay@...y.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH v3] tty: Set correct tty name in 'active' sysfs attribute

On 02/27/2014 12:30 PM, David Herrmann wrote:
> From: Hannes Reinecke <hare@...e.de>
> 
> The 'active' sysfs attribute should refer to the currently active tty
> devices the console is running on, not the currently active console. The
> console structure doesn't refer to any device in sysfs, only the tty the
> console is running on has. So we need to print out the tty names in
> 'active', not the console names.
> 
> There is one special-case, which is tty0. If the console is directed to
> it, we want 'tty0' to show up in the file, so user-space knows that the
> messages get forwarded to the active VT. The ->device() callback would
> resolve tty0, though. Hence, treat it special and don't call into the VT
> layer to resolve it (plymouth is known to depend on it).
> 
> Cc: Lennart Poettering <lennart@...ttering.net>
> Cc: Kay Sievers <kay@...y.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Slaby <jslaby@...e.cz>
> Signed-off-by: Werner Fink <werner@...e.de>
> Signed-off-by: Hannes Reinecke <hare@...e.de>
> Signed-off-by: David Herrmann <dh.herrmann@...il.com>
> ---
> v2: use cs[i]->index instead of ->index
>     refactor code to avoid >80 lines
>     split out sprintf("%c",...);
> 
> Tested on my x86-64 machine.

Thanks for this.
Patch looks good.

Acked-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/