linux-kernel - Re: [PATCH v9 3/3] mmc: sdhci-msm: Add platform_execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 01 Mar 2014 00:29:53 +0200
From:	Georgi Djakov <gdjakov@...sol.com>
To:	Josh Cartwright <joshc@...eaurora.org>
CC:	linux-mmc@...r.kernel.org, cjb@...top.org, ulf.hansson@...aro.org,
	devicetree@...r.kernel.org, grant.likely@...aro.org,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	swarren@...dotorg.org, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, rob@...dley.net, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v9 3/3] mmc: sdhci-msm: Add platform_execute_tunning implementation

On 28.02.14, 22:51, Josh Cartwright wrote:
[..]
>> +		sg_init_one(&sg, data_buf, sizeof(data_buf));
>> +		memset(data_buf, 0, sizeof(data_buf));
>> +		mmc_wait_for_req(mmc, &mrq);
>> +
>> +		if (!cmd.error && !data.error &&
>> +		    !memcmp(data_buf, tuning_block_pattern, sizeof(data_buf))) {
> 
> This memcmp is broken, sizeof(data_buf) is likely not what you want,
> maybe you want 'size'?  Same thing for sg_init_one()/memset() above.
> 
> From sparse:
> 
> drivers/mmc/host/sdhci-msm.c: In function â€˜sdhci_msm_execute_tuningâ€™:
> drivers/mmc/host/sdhci-msm.c:461:53: warning: argument to â€˜sizeofâ€™ in â€˜memcmpâ€™ call is the same expression as the first source; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess]
>        !memcmp(data_buf, tuning_block_pattern, sizeof(data_buf))) {
> 

Nice catch, Josh! Thanks for reviewing!

BR,
Georgi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/