linux-kernel - Re: [PATCH 1/3] staging/usbip: add uapi header to export usbip kernel interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <53111190.4020907@samsung.com>
Date:	Fri, 28 Feb 2014 15:45:36 -0700
From:	Shuah Khan <shuah.kh@...sung.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	ly80toro@....cs.fau.de, andy.grover@...il.com,
	valentina.manea.m@...il.com, linux-usb@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	shuahkhan@...il.com, Shuah Khan <shuah.kh@...sung.com>
Subject: Re: [PATCH 1/3] staging/usbip: add uapi header to export usbip kernel
 interfaces

On 02/28/2014 03:15 PM, Greg KH wrote:
> On Thu, Feb 27, 2014 at 05:27:25PM -0700, Shuah Khan wrote:
>> usbip userspace has duplicated enum definition to report usbip device
>> status maintained by the kernel. Adding an usbip uapi header file will
>> define the kernel - userspace interface for this device status.
>>
>> Signed-off-by: Shuah Khan <shuah.kh@...sung.com>
>> ---
>>   include/uapi/linux/Kbuild  |    1 +
>>   include/uapi/linux/usbip.h |   26 ++++++++++++++++++++++++++
>>   2 files changed, 27 insertions(+)
>>   create mode 100644 include/uapi/linux/usbip.h
>
> Staging code should be self-contained within drivers/staging/
>
> Now I know that a bunch of people are now working on this codebase, and
> hopefully it will finally get moved out of staging someday soon, but
> until then, I can't add this file in this location, sorry.

That makes sense.

>
> Look at how the drivers/staging/android code handles the uapi files, you
> should try doing that instead.
>

I will take a look at how android is handling uapi files and redo this 
patch series and resend it. Hope everybody is ok with the code itself, 
just the location of the uapi file is the issue, if not please let me 
know and give me feedback on the approach.

-- Shuah


-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@...sung.com | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/