linux-kernel - Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140228232223.GB23878@earth.universe>
Date:	Sat, 1 Mar 2014 00:22:23 +0100
From:	Sebastian Reichel <sre@...ian.org>
To:	Belisko Marek <marek.belisko@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

Hi Marek,

On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote:
> Seems I found issue. I have missing property ti,system-uses-second-madc-irq
> as original twl4030_madc_battery used SW2 but this change doesn't fix completely
> the problem.

I remember adding this property because you requested it :) Good to
know, that its really needed.

> What it fixed completely is change:
> -       req.raw = !(mask == IIO_CHAN_INFO_PROCESSED);
> +       req.raw = 0;//!(mask == IIO_CHAN_INFO_PROCESSED);

ok, that figures it. Instead of changing the twl4030-madc driver
you should change the twl4030-madc-battery driver. You currently
call iio_read_channel_raw(), which gives you raw values. Your
driver wants processed data from twl4030-madc, so you should use
iio_read_channel_processed() instead.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)