linux-kernel - Re: [PATCH] Staging:tidspbridge: Fixing coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 1 Mar 2014 12:11:44 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Masood Mehmood <ody.guru@...il.com>
Cc:	Omar Ramirez Luna <omar.ramirez@...itl.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:tidspbridge: Fixing coding style

This patch introduces bugs.

On Fri, Feb 28, 2014 at 06:15:52PM -0800, Masood Mehmood wrote:
> 

> 
> Fixing some basic coding style issues.
> 

Changelog sucks.  Doesn't say what the changes are.

> Signed-off-by: Masood Mehmood <ody.guru@...il.com>
> ---
>  drivers/staging/tidspbridge/rmgr/node.c | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/tidspbridge/rmgr/node.c b/drivers/staging/tidspbridge/rmgr/node.c
> index 87dfa92..76f885f 100644
> --- a/drivers/staging/tidspbridge/rmgr/node.c
> +++ b/drivers/staging/tidspbridge/rmgr/node.c
> @@ -246,7 +246,7 @@ static void fill_stream_def(struct node_object *hnode,
>  			    struct node_strmdef *pstrm_def,
>  			    struct dsp_strmattr *pattrs);
>  static void free_stream(struct node_mgr *hnode_mgr, struct stream_chnl stream);
> -static int get_fxn_address(struct node_object *hnode, u32 * fxn_addr,
> +static int get_fxn_address(struct node_object *hnode, u32 *fxn_addr,
>  				  u32 phase);
>  static int get_node_props(struct dcd_manager *hdcd_mgr,
>  				 struct node_object *hnode,
> @@ -406,7 +406,7 @@ int node_allocate(struct proc_object *hprocessor,
>  
>  	/* check for page aligned Heap size */
>  	if (((attr_in->heap_size) & (PG_SIZE4K - 1))) {
> -		pr_err("%s: node heap size not aligned to 4K, size = 0x%x \n",
> +		pr_err("%s: node heap size not aligned to 4K, size = 0x%x",

The correct fix here is:

		pr_err("%s: node heap size not aligned to 4K, size = 0x%x\n",

>  		       __func__, attr_in->heap_size);
>  		status = -EINVAL;
>  	} else {
> @@ -425,7 +425,7 @@ int node_allocate(struct proc_object *hprocessor,
>  					task_arg_obj.dsp_heap_res_addr),
>  				     pr_ctxt);
>  	if (status) {
> -		pr_err("%s: Failed to reserve memory for heap: 0x%x\n",
> +		pr_err("%s: Failed to reserve memory for heap: 0x%x",

What??

>  		       __func__, status);
>  		goto func_cont;
>  	}
> @@ -703,9 +703,9 @@ DBAPI node_alloc_msg_buf(struct node_object *hnode, u32 usize,
>  		pattr = &node_dfltbufattrs;	/* set defaults */
>  
>  	status = proc_get_processor_id(pnode->processor, &proc_id);
> -	if (proc_id != DSP_UNIT) {
> +	if (proc_id != DSP_UNIT)
>  		goto func_end;
> -	}
> +
>  	/*  If segment ID includes MEM_SETVIRTUALSEGID then pbuffer is a
>  	 *  virt  address, so set this info in this node's translator
>  	 *  object for  future ref. If MEM_GETVIRTUALSEGID then retrieve
> @@ -886,11 +886,10 @@ int node_connect(struct node_object *node1, u32 stream1,
>  	if (pattrs && pattrs->strm_mode != STRMMODE_PROCCOPY)
>  		return -EPERM;	/* illegal stream mode */
>  
> -	if (node1_type != NODE_GPP) {
> +	if (node1_type != NODE_GPP)
>  		hnode_mgr = node1->node_mgr;
> -	} else {
> +	else
>  		hnode_mgr = node2->node_mgr;
> -	}
>  
>  	/* Enter critical section */
>  	mutex_lock(&hnode_mgr->node_mgr_lock);
> @@ -1576,7 +1575,7 @@ func_end:
>   *  Purpose:
>   *      Frees the message buffer.
>   */
> -int node_free_msg_buf(struct node_object *hnode, u8 * pbuffer,
> +int node_free_msg_buf(struct node_object *hnode, u8 *pbuffer,
>  			     struct dsp_bufferattr *pattr)
>  {
>  	struct node_object *pnode = (struct node_object *)hnode;
> @@ -2322,7 +2321,8 @@ int node_terminate(struct node_object *hnode, int *pstatus)
>  			if (!hdeh_mgr)
>  				goto func_cont;
>  
> -			bridge_deh_notify(hdeh_mgr, DSP_SYSERROR, DSP_EXCEPTIONABORT);
> +			bridge_deh_notify(hdeh_mgr, DSP_SYSERROR,
> +							DSP_EXCEPTIONABORT);

Do it like this:

			bridge_deh_notify(hdeh_mgr, DSP_SYSERROR,
					  DSP_EXCEPTIONABORT);


regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/