linux-kernel - Re: [RFC] [PATCH 4/6] media: em28xx-input - implement em28xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20140301104835.631c65bb@samsung.com>
Date:	Sat, 01 Mar 2014 10:48:35 -0300
From:	Mauro Carvalho Chehab <m.chehab@...sung.com>
To:	Shuah Khan <shuah.kh@...sung.com>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	shuahkhan@...il.com
Subject: Re: [RFC] [PATCH 4/6] media: em28xx-input - implement em28xx_ops:
 suspend/resume hooks

Em Fri, 21 Feb 2014 17:50:16 -0700
Shuah Khan <shuah.kh@...sung.com> escreveu:

> Implement em28xx_ops: suspend/resume hooks. em28xx usb driver will
> invoke em28xx_ops: suspend and resume hooks for all its extensions
> from its suspend() and resume() interfaces.
> 
> Signed-off-by: Shuah Khan <shuah.kh@...sung.com>
> ---
>  drivers/media/usb/em28xx/em28xx-input.c | 35 +++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers/media/usb/em28xx/em28xx-input.c
> index 18f65d8..1227309 100644
> --- a/drivers/media/usb/em28xx/em28xx-input.c
> +++ b/drivers/media/usb/em28xx/em28xx-input.c
> @@ -827,11 +827,46 @@ static int em28xx_ir_fini(struct em28xx *dev)
>  	return 0;
>  }
>  
> +static int em28xx_ir_suspend(struct em28xx *dev)
> +{
> +	struct em28xx_IR *ir = dev->ir;
> +
> +	if (dev->is_audio_only)
> +		return 0;
> +
> +	em28xx_info("Suspending input extension");
> +	cancel_delayed_work_sync(&ir->work);
> +	cancel_delayed_work_sync(&dev->buttons_query_work);
> +	/* is canceling delayed work sufficient or does the rc event
> +	   kthread needs stopping? kthread is stopped in
> +	   ir_raw_event_unregister() */
> +	return 0;
> +}
> +
> +static int em28xx_ir_resume(struct em28xx *dev)
> +{
> +	struct em28xx_IR *ir = dev->ir;
> +
> +	if (dev->is_audio_only)
> +		return 0;
> +
> +	em28xx_info("Resuming input extension");
> +	/* if suspend calls ir_raw_event_unregister(), the should call
> +	   ir_raw_event_register() */
> +	schedule_delayed_work_sync(&ir->work);

This causes a compilation breakage:

drivers/media/usb/em28xx/em28xx-input.c: In function ‘em28xx_ir_resume’:
drivers/media/usb/em28xx/em28xx-input.c:856:2: error: implicit declaration of function ‘schedule_delayed_work_sync’ [-Werror=implicit-function-declaration]
  schedule_delayed_work_sync(&ir->work);


> +	if (dev->num_button_polling_addresses)
> +		schedule_delayed_work(&dev->buttons_query_work,
> +			       msecs_to_jiffies(dev->button_polling_interval));
> +	return 0;
> +}
> +
>  static struct em28xx_ops rc_ops = {
>  	.id   = EM28XX_RC,
>  	.name = "Em28xx Input Extension",
>  	.init = em28xx_ir_init,
>  	.fini = em28xx_ir_fini,
> +	.suspend = em28xx_ir_suspend,
> +	.resume = em28xx_ir_resume,
>  };
>  
>  static int __init em28xx_rc_register(void)


-- 

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/