linux-kernel - Re: [PATCH 7/9] drivers: staging: rtl8187se: fixed checkpatch.pl errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393738591.31402.23.camel@joe-AO722>
Date:	Sat, 01 Mar 2014 21:36:31 -0800
From:	Joe Perches <joe@...ches.com>
To:	Axel Rasmussen <axel.rasmussen1@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 7/9] drivers: staging: rtl8187se: fixed checkpatch.pl
 errors

On Sat, 2014-03-01 at 22:22 -0700, Axel Rasmussen wrote:
> The definition of the driver's ChannelPlan array produced a large number
> of checkpatch.pl errors. This patch fixes all of them by adding spaces
> and wrapping the resulting overly-long lines.

I think the current code is better.

> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
[]
> @@ -2242,17 +2242,44 @@ static void watch_dog_adaptive(unsigned long data)
[for instance]
>  static struct rtl8187se_channel_list channel_plan_list[] = {
> -	{{1,2,3,4,5,6,7,8,9,10,11,36,40,44,48,52,56,60,64},19},		/* FCC */
[]
> +	/* FCC */
> +	{{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 36, 40,
> +		44, 48, 52, 56, 60, 64}, 19},

If you really do this, it may be better to
remove the len variable and test for != 0
instead of channel_plan_list[].len

So instead of:

drivers/staging/rtl8187se/r8180_core.c:
			for (i = 0; i < channel_plan_list[channel_plan].len; i++) {
Maybe:
			for (i = 0; channel_plan_list[channel_plan].channel[i]; i++) {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/