linux-kernel - Re: [PATCH] pstore: skip zero size persistent ram buffer in traverse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5312F47B.8080603@linux.intel.com>
Date:	Sun, 02 Mar 2014 17:06:03 +0800
From:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
To:	shuox.liu@...el.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
CC:	tony.luck@...el.com, keescook@...omium.org, ccross@...roid.com,
	anton@...msg.org
Subject: Re: [PATCH] pstore: skip zero size persistent ram buffer in traverse

On 2014/2/28 14:38, shuox.liu@...el.com wrote:
> From: Liu ShuoX <shuox.liu@...el.com>
>
> In ramoops_pstore_read, a valid prz pointer with zero size buffer will
> break traverse of all persistent ram buffers. The latter buffer might
> be lost.

Andrew,

Would you like to merge it to your testing tree?
pstore is a very important feature for debugging hard issues on
Android mobiles.

Yanmin

>
> Signed-off-by: Liu ShuoX <shuox.liu@...el.com>
> ---
>   fs/pstore/ram.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index a5d0cab..929ea55 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -119,12 +119,12 @@ ramoops_get_next_prz(struct persistent_ram_zone *przs[], uint *c, uint max,
>   
>   	prz = przs[i];
>   
> -	if (update) {
> -		/* Update old/shadowed buffer. */
> +	/* Update old/shadowed buffer. */
> +	if (update)
>   		persistent_ram_save_old(prz);
> -		if (!persistent_ram_old_size(prz))
> -			return NULL;
> -	}
> +
> +	if (!persistent_ram_old_size(prz))
> +		return NULL;
>   
>   	*typep = type;
>   	*id = i;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/