linux-kernel - Re: [iio:togreg 3/3] WARNING: Reusing the krealloc arg is almost always a bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5312F5BC.7080607@metafoo.de>
Date:	Sun, 02 Mar 2014 10:11:24 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Fengguang Wu <fengguang.wu@...el.com>
CC:	Jonathan Cameron <jic23@...nel.org>, Joe Perches <joe@...ches.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [iio:togreg 3/3] WARNING: Reusing the krealloc arg is almost
 always a bug

On 03/02/2014 03:24 AM, Fengguang Wu wrote:
>
> Hi Lars-Peter,
>
> FYI, there are new warnings show up in
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> head:   bdc8cda1d010887c06bd8c29564b74cd61ec0a7b
> commit: bdc8cda1d010887c06bd8c29564b74cd61ec0a7b [3/3] iio:adc: Add Xilinx XADC driver
>
> scripts/checkpatch.pl 0001-iio-adc-Add-Xilinx-XADC-driver.patch
> # many are suggestions rather than must-fix
> WARNING: Reusing the krealloc arg is almost always a bug
> #1220: drivers/iio/adc/xilinx-xadc-core.c:1138:
> +	indio_dev->channels = krealloc(channels, sizeof(*channels) *
>

This is actually a false positive, checkpatch thinks that 
'indio_dev->channels' and 'channels' is the same. Added Joe to Cc.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/