linux-kernel - Re: [PATCH 4/9] drivers: staging: rtl8187se: wrap excessively long lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Mar 2014 12:02:27 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Axel Rasmussen <axel.rasmussen1@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] drivers: staging: rtl8187se: wrap excessively long
 lines

On Sat, Mar 01, 2014 at 10:22:48PM -0700, Axel Rasmussen wrote:
> Signed-off-by: Axel Rasmussen <axel.rasmussen1@...il.com>
> ---
>  drivers/staging/rtl8187se/r8180_core.c | 73 ++++++++++++++++++++--------------
>  1 file changed, 44 insertions(+), 29 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index b6c8c00..cd22ba3 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -1021,7 +1021,8 @@ inline u16 ieeerate2rtlrate(int rate)
>  	}
>  }
>  
> -static u16 rtl_rate[] = {10, 20, 55, 110, 60, 90, 120, 180, 240, 360, 480, 540, 720};
> +static u16 rtl_rate[] = {10, 20, 55, 110, 60,
> +	90, 120, 180, 240, 360, 480, 540, 720};
>  
>  inline u16 rtl8180_rate2rate(short rate)
>  {
> @@ -1236,7 +1237,8 @@ static void rtl8180_rx(struct net_device *dev)
>  		tmp = priv->rxringtail;
>  		do {
>  			if (tmp == priv->rxring)
> -				tmp  = priv->rxring + (priv->rxringcount - 1)*rx_desc_size;
> +				tmp  = priv->rxring + (priv->rxringcount - 1) *
> +					rx_desc_size;
>  			else
>  				tmp -= rx_desc_size;
>  
> @@ -1322,21 +1324,26 @@ static void rtl8180_rx(struct net_device *dev)
>  			priv->rx_skb_complete = 1;
>  		}
>  
> -		signal = (unsigned char)(((*(priv->rxringtail+3)) & (0x00ff0000))>>16);
> +		signal = (unsigned char)(*(priv->rxringtail + 3) &
> +			0x00ff0000) >> 16;

Nope.  This introduces a bug.

I have not reviewed any further into this patch.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/