linux-kernel - Re: [PATCH] mm: zswap: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 3 Mar 2014 08:39:48 -0600
From:	Seth Jennings <sjennings@...iantweb.net>
To:	SeongJae Park <sj38.park@...il.com>
Cc:	sjenning@...ux.vnet.ibm.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: zswap: remove unnecessary parentheses

On Mon, Mar 03, 2014 at 06:37:56PM +0900, SeongJae Park wrote:
> Fix following trivial checkpatch error:
> 	ERROR: return is not a function, parentheses are not required
> 
> Signed-off-by: SeongJae Park <sj38.park@...il.com>

Thanks for the cleanup.
Might copy trivial@...nel.org on patches like this in the future.

Acked-by: Seth Jennings <sjennings@...iantweb.net>

> ---
>  mm/zswap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/zswap.c b/mm/zswap.c
> index c0c9b7c..34b75cc 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -204,7 +204,7 @@ static struct kmem_cache *zswap_entry_cache;
>  static int zswap_entry_cache_create(void)
>  {
>  	zswap_entry_cache = KMEM_CACHE(zswap_entry, 0);
> -	return (zswap_entry_cache == NULL);
> +	return zswap_entry_cache == NULL;
>  }
>  
>  static void zswap_entry_cache_destory(void)
> @@ -408,8 +408,8 @@ cleanup:
>  **********************************/
>  static bool zswap_is_full(void)
>  {
> -	return (totalram_pages * zswap_max_pool_percent / 100 <
> -		zswap_pool_pages);
> +	return totalram_pages * zswap_max_pool_percent / 100 <
> +		zswap_pool_pages;
>  }
>  
>  /*********************************
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/