linux-kernel - Re: Ethernet controller not starting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3049227.1OEyu61877@vostro.rjw.lan>
Date:	Tue, 04 Mar 2014 00:43:14 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Jon Ringle <jon@...gle.org>
Cc:	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	rafael.j.wysocki@...el.com
Subject: Re: Ethernet controller not starting

On Monday, March 03, 2014 02:41:01 PM Jon Ringle wrote:
> I'm working on porting an ARM board from linux-3.10 to linux-3.12 (now
> the latest LTS kernel).
> I found that Ethernet controller on the board no longer comes up on linux-3.12.
> I was able to bisect the issue I'm having to the following commit:
> 
> >   45f0a85c8258741d11bda25c0a5669c06267204a is the first bad commit
> >   commit 45f0a85c8258741d11bda25c0a5669c06267204a
> >   Author: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >   Date:   Mon Jun 3 21:49:52 2013 +0200
> >
> >       PM / Runtime: Rework the "runtime idle" helper routine
> >
> >       The "runtime idle" helper routine, rpm_idle(), currently ignores
> >       return values from .runtime_idle() callbacks executed by it.
> >       However, it turns out that many subsystems use
> >       pm_generic_runtime_idle() which checks the return value of the
> >       driver's callback and executes pm_runtime_suspend() for the device
> >       unless that value is not 0.  If that logic is moved to rpm_idle()
> >       instead, pm_generic_runtime_idle() can be dropped and its users
> >       will not need any .runtime_idle() callbacks any more.
> >
> >       Moreover, the PCI, SCSI, and SATA subsystems' .runtime_idle()
> >       routines, pci_pm_runtime_idle(), scsi_runtime_idle(), and
> >       ata_port_runtime_idle(), respectively, as well as a few drivers'
> >       ones may be simplified if rpm_idle() calls rpm_suspend() after 0 has
> >       been returned by the .runtime_idle() callback executed by it.
> >
> >       To reduce overall code bloat, make the changes described above.
> >
> >       Tested-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> >       Tested-by: Kevin Hilman <khilman@...aro.org>
> >       Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >       Acked-by: Kevin Hilman <khilman@...aro.org>
> >       Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>
> >       Acked-by: Alan Stern <stern@...land.harvard.edu>
> 
> Can anyone offer any suggestions on what I should be looking for to
> fix this on my board?

Any pointers to the driver in question?

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/