linux-kernel - Re: [PATCH v6 00/14] uprobes: Add uprobes support for ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140304005306.GO21483@n2100.arm.linux.org.uk>
Date:	Tue, 4 Mar 2014 00:53:06 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	David Long <dave.long@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, Rabin Vincent <rabin@....in>,
	"Jon Medhurst (Tixy)" <tixy@...aro.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...hat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	davem@...emloft.net, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 00/14] uprobes: Add uprobes support for ARM

On Mon, Mar 03, 2014 at 09:50:39PM +0100, Oleg Nesterov wrote:
> On 03/02, David Long wrote:
> >
> > Oleg,
> >
> > I've been looking at arch/Kconfig and kernel/trace/Kconfig where they
> > deal with uprobes.  The relevant items are CONFIG_UPROBES and
> > CONFIG_UPROBE_EVENT.  It just doesn't look right to me.
> 
> Yes, this looks strange. I never understood these dependencies. In fact
> I even never tried. And I do not really understand kbuild, unfortunately...
> 
> >> --- a/arch/Kconfig
> >> +++ b/arch/Kconfig
> >> @@ -87,7 +87,8 @@ config KPROBES_ON_FTRACE
> >>
> >>  config UPROBES
> >>  	bool "Transparent user-space probes (EXPERIMENTAL)"
> >> -	depends on UPROBE_EVENT && PERF_EVENTS
> >> +	depends on ARCH_SUPPORTS_UPROBES
> >> +	depends on PERF_EVENTS
> 
> And why CONFIG_UPROBES should depend on PERF_EVENTS? uprobes can be
> used by (say) systemtap without UPROBE_EVENT/PERF_EVENTS.
> 
> But as Russell pointed out the events directory is only built if
> CONFIG_PERF_EVENTS=y, so it should depend on it or select...
> 
> 
> I dunno. Personally I vote for the patch from Srikar in
> 
> 	http://article.gmane.org/gmane.linux.kernel/1017186
> 
> This is what we currently have, currently CONFIG_UPROBES is not
> user-selectable anyway.

Yes, me too, but with the proviso that UPROBE_EVENT also sorts itself
out with PERF_EVENTS in some way too (either by selecting it, which
IMHO isn't nice, or by depending on it, or the build dependency itself
gets sorted.)

Maybe a simpler answer would be to change the build stuff (hand-crafted):

kernel/Makefile
-obj-$(CONFIG_PERF_EVENTS) += events/
+obj-y += events/

and kernel/events/Makefile:

-obj-y := core.o ring_buffer.o callchain.o
+perf-y := core.o ring_buffer.o callchain.o

-obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o
+perf-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o
+
+obj-${CONFIG_PERF_EVENTS) += $(perf-y)

?

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/