linux-kernel - Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 4 Mar 2014 19:18:03 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	shaun@...source.ca, sachin.kamat@...aro.org,
	linux-kernel@...r.kernel.org, ying.xue@...driver.com,
	davem@...emloft.net
Subject: Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in
 if condition'

Yes, it need to add brace in inner loop.
I will send again.

Thanks for review.
Daeseok Youn

2014-03-04 18:04 GMT+09:00, Dan Carpenter <dan.carpenter@...cle.com>:
> On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
>> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
>>  			ci = (ci_t *)(netdev_priv(hi->ndev));
>>  			for (j = 0; j < ci->max_port; j++)
>>  				for (k = 0; k < MUSYCC_NCHANS; k++)
>> -					if ((ndev = ci->port[j].chan[k]->user))
>> +					ndev = ci->port[j].chan[k]->user;
>> +					if (ndev)
>>  					{
>>  						do_deluser(ndev, 0);
>>  					}
>
>
> This patch introduces a bug here because the inner for loop now has two
> statement but no curly braces.
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/