linux-kernel - Re: [PATCH] IOMMU: iommu module do not check NULL return of kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 4 Mar 2014 16:41:18 +0100
From:	Joerg Roedel <joro@...tes.org>
To:	Zhouyi Zhou <zhouzhouyi@...il.com>
Cc:	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	Zhouyi Zhou <yizhouzhou@....ac.cn>
Subject: Re: [PATCH] IOMMU: iommu module do not check NULL return of
 kmem_cache_zalloc

On Tue, Feb 11, 2014 at 10:12:53AM +0800, Zhouyi Zhou wrote:
> From: Zhouyi Zhou <yizhouzhou@....ac.cn>
> 
> The function iopte_alloc do not check NULL return of kmem_cache_zalloc,
> call iopte_free with argument 0 will panic.
> 
> Signed-off-by: Zhouyi Zhou <yizhouzhou@....ac.cn>
> ---
>  drivers/iommu/omap-iommu.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index bcd78a7..5155714 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -551,7 +551,8 @@ static u32 *iopte_alloc(struct omap_iommu *obj, u32 *iopgd, u32 da)
>  		dev_vdbg(obj->dev, "%s: a new pte:%p\n", __func__, iopte);
>  	} else {
>  		/* We raced, free the reduniovant table */
> -		iopte_free(iopte);
> +		if (iopte)
> +			iopte_free(iopte);

Isn't it better to put the check into iopte_free?


	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/