linux-kernel - Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140304195541.GB24463@saruman.home>
Date:	Tue, 4 Mar 2014 13:55:41 -0600
From:	Felipe Balbi <balbi@...com>
To:	Michal Nazarewicz <mina86@...a86.com>
CC:	Robert Baldyga <r.baldyga@...sung.com>,
	Felipe Balbi <balbi@...com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Chuansheng Liu <chuansheng.liu@...el.com>,
	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <david.a.cohen@...ux.intel.com>
Subject: Re: [PATCH v2] usb: gadget: return the right length in
 ffs_epfile_io()

On Tue, Mar 04, 2014 at 08:53:40PM +0100, Michal Nazarewicz wrote:
> >> On 03/04/2014 10:34 AM, Chuansheng Liu wrote:
> >> >@@ -845,12 +845,14 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data)
> >> >  			 * we may end up with more data then user space has
> >> >  			 * space for.
> >> >  			 */
> >> >-			ret = ep->status;
> >> >-			if (io_data->read && ret > 0 &&
> >> >-			    unlikely(copy_to_user(io_data->buf, data,
> >> >-						  min_t(size_t, ret,
> >> >-						  io_data->len))))
> >> >-				ret = -EFAULT;
> >> >+				ret = ep->status;
> 
> On Tue, Mar 04 2014, Felipe Balbi wrote:
> >>    Why the indentation jumped suddenly to the right?
> 
> > On Tue, Mar 04, 2014 at 08:01:15PM +0300, Sergei Shtylyov wrote:
> > because it was wrong before ;-)
> 
> Yep.  It looks like Robert's [2e4c7553: add aio support] introduced an
> if-else-if-else flow but did not indent the code and I didn't caught it
> when reviewing that patch.

it's in my testing/next now, I also fixed the comment indentation which
was also wrong.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)