linux-kernel - Re: [PATCH 28/44] Add translate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53163ADE.8080905@nod.at>
Date:	Tue, 04 Mar 2014 21:43:10 +0100
From:	Richard Weinberger <richard@....at>
To:	Oleg Nesterov <oleg@...hat.com>
CC:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	viro@...iv.linux.org.uk, vgupta@...opsys.com,
	catalin.marinas@....com, will.deacon@....com,
	hskinnemoen@...il.com, egtvedt@...fundet.no, vapier@...too.org,
	msalter@...hat.com, a-jacquiot@...com, starvik@...s.com,
	jesper.nilsson@...s.com, dhowells@...hat.com, rkuo@...eaurora.org,
	tony.luck@...el.com, fenghua.yu@...el.com, takata@...ux-m32r.org,
	geert@...ux-m68k.org, james.hogan@...tec.com, monstr@...str.eu,
	yasutake.koichi@...panasonic.com, ralf@...ux-mips.org,
	jonas@...thpole.se, jejb@...isc-linux.org, deller@....de,
	benh@...nel.crashing.org, paulus@...ba.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, liqin.linux@...il.com,
	lennox.wu@...il.com, cmetcalf@...era.com, gxt@...c.pku.edu.cn,
	linux-xtensa@...ux-xtensa.org, akpm@...ux-foundation.org,
	tj@...nel.org, hch@...radead.org
Subject: Re: [PATCH 28/44] Add translate_signal() helper

Am 04.03.2014 19:41, schrieb Oleg Nesterov:
> On 03/03, Richard Weinberger wrote:
>>
>> +static inline int translate_signal(int sig)
>> +{
>> +	struct thread_info *info = current_thread_info();
>> +
>> +	if (info->exec_domain
> 
> Afaics it can't be NULL.

Good point. Will change.

>> && info->exec_domain->signal_invmap && sig < 32)
>> +		return info->exec_domain->signal_invmap[sig];
>> +
> 
> And why default_exec_domain has .signal_invmap = ident_map ?
> translate_signal-like code should check ->signal_invmap != NULL
> anyway.
> 
> Off topic, but can't we kill exec_domain->signal_map ? it seems that
> it is unused.
> 
> Hmm. And who actually uses exec_domain->handler() ?? asm-offsets.c,
> but I do not see any usage of TI_EXEC_DOMAIN.
> 
> In short: I agree with this change but I am totally confused. To the
> point, I am not sure I even understand ->signal_invmap. I mean, it
> seems that only arthur_exec_domain has a non-ident map. Why, say,
> x86 does signr_convert() ? and only if CONFIG_X86_32? Is there any
> external module which does register_exec_domain(strange_invmap) ?

I remember a discussion with Al where he noted that register_exec_domain()
is currently only used by out of tree horrors. B-)

I'm sure we can rip it out of most archs. They seem to have it only because
they've copy&pasted it from i386.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/