linux-kernel - Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140304220238.GA11789@earth.universe>
Date:	Tue, 4 Mar 2014 23:02:40 +0100
From:	Sebastian Reichel <sre@...ian.org>
To:	Belisko Marek <marek.belisko@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

Hi,

On Tue, Mar 04, 2014 at 10:20:32PM +0100, Belisko Marek wrote:
> On Sat, Mar 1, 2014 at 12:22 AM, Sebastian Reichel <sre@...ian.org> wrote:
> > On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote:
> >> Seems I found issue. I have missing property ti,system-uses-second-madc-irq
> >> as original twl4030_madc_battery used SW2 but this change doesn't fix completely
> >> the problem.
> >
> > I remember adding this property because you requested it :) Good to
> > know, that its really needed.
> >
> >> What it fixed completely is change:
> >> -       req.raw = !(mask == IIO_CHAN_INFO_PROCESSED);
> >> +       req.raw = 0;//!(mask == IIO_CHAN_INFO_PROCESSED);
> >
> > ok, that figures it. Instead of changing the twl4030-madc driver
> > you should change the twl4030-madc-battery driver. You currently
> > call iio_read_channel_raw(), which gives you raw values. Your
> > driver wants processed data from twl4030-madc, so you should use
> > iio_read_channel_processed() instead.
> Yes this helps but also not completely :(. twl4030_madc_battery using
> chanel 1, 10, 12. Channel 1 and 10 have flag IIO_CHAN_INFO_PROCESSED
> set but channel 12 not and values from channel 12 are read as raw which is not
> what I want.

mh. I should have added IIO_CHAN_INFO_PROCESSED for all channels
and not just for current & temperature special cases.

I will send an updated patchset.

> Can I simply add IIO_CHAN_INFO_PROCESSED also to channel 12?

Yes, but if you wait some minutes you can use my updated
twl4030-madc patchset. This way you can add your Tested-by
once its working.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)