linux-kernel - Re: [PATCH] x86, apic, Fix missing replacement for VECTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1403041436050.5421@chino.kir.corp.google.com>
Date:	Tue, 4 Mar 2014 14:37:50 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Prarit Bhargava <prarit@...hat.com>
cc:	linux-kernel@...r.kernel.org, Rui Wang <rui.y.wang@...el.com>,
	Michel Lespinasse <walken@...gle.com>,
	Seiji Aguchi <seiji.aguchi@....com>,
	Yang Zhang <yang.z.zhang@...el.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	janet.morgan@...el.com, tony.luck@...el.com, ruiv.wang@...il.com
Subject: Re: [PATCH] x86, apic, Fix missing replacement for
 VECTOR_UNDEFINED

On Tue, 4 Mar 2014, Prarit Bhargava wrote:

> linux.git commit 9345005f4eed805308193658d12e4e7e9c261e74 added
> a definition for VECTOR_UNDEFINED = -1.  There is a missing replacement in
> the io_apic.c file.  Found during debugging of another issue.
> 
> Cc: Rui Wang <rui.y.wang@...el.com>
> Cc: Michel Lespinasse <walken@...gle.com>
> Cc: Seiji Aguchi <seiji.aguchi@....com>
> Cc: Yang Zhang <yang.z.zhang@...el.com>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: janet.morgan@...el.com
> Cc: tony.luck@...el.com
> Cc: ruiv.wang@...il.com
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>

Acked-by: David Rientjes <rientjes@...gle.com>

I think it would have been better to define VECTOR_UNDEFINED to be (-1) 
rather than -1, though, to ensure it can't be used erroneously as an 
arithmetic operation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/