linux-kernel - Re: Closing on the CR2 leak bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140304184112.0a3fe811@gandalf.local.home>
Date:	Tue, 4 Mar 2014 18:41:12 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Vince Weaver <vincent.weaver@...ne.edu>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Seiji Aguchi <seiji.aguchi@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Closing on the CR2 leak bug

On Tue, 04 Mar 2014 14:34:00 -0800
"H. Peter Anvin" <hpa@...or.com> wrote:

> So we need to get something into x86/urgent for the CR2 bug.
> 
> It seems like a no-brainer to do the hoisting patch, for which I prefer
> the version proposed by Jiri Olsa which reads %cr2 and then passes it to
> __do_page_fault() in a GPR:
> 
> http://lkml.kernel.org/r/20140228160526.GD1133@krava.brq.redhat.com
> 
> As fart as I can tell this should fix Vince's problem as well.
> 
> Anyone who objects to this?  Otherwise I will put it in tip:x86/urgent
> tomorrow.
> 
> Do we need any more refinements this late in the -rc cycle?
> 

The only other issue is if perf traces from function context and traces
the trace_do_page_fault() call. But other than that, sure, take Jiri's
patch.

Acked-by: Steven Rostedt <rostedt@...dmis.org>

Please also add the reported/tested-by from Vince Weaver and add a
Link: to the other thread, as it got pretty detailed there too.


 -- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/