linux-kernel - Re: [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531696A9.6060906@wwwdotorg.org>
Date:	Tue, 04 Mar 2014 20:14:49 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Wei Ni <wni@...dia.com>
CC:	Guenter Roeck <linux@...ck-us.net>,
	"khali@...ux-fr.org" <khali@...ux-fr.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>
Subject: Re: [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008

On 03/04/2014 08:07 PM, Wei Ni wrote:
> On 03/05/2014 10:58 AM, Stephen Warren wrote:
>> On 03/04/2014 07:30 PM, Wei Ni wrote:
>>> On 03/05/2014 06:23 AM, Guenter Roeck wrote:
>>>> On Tue, Mar 04, 2014 at 03:06:48PM -0700, Stephen Warren wrote:
>>>>> On 03/04/2014 04:31 AM, Wei Ni wrote:
>>>>>> Add dt node to describe the thermal zone for the nct1008.
>>>>>>
>>>>>> Change-Id: I0256836e52d73ec282574e4fd91df52958936e35
>>>>>
>>>>> ???????
>>>>>
>>>> I think this is for one of those open-source sites out there
>>>> which count open source contributions. Not Ohloh, but similar.
>>>> You have to specify that Change-Id to have it associate your
>>>> name with the patch.
>>>
>>> It's so sorry, I'm working for chromiumos, this change-id is generated
>>> by gerrit, I should remove it.
>>>
>>>>
>>>> Guenter
>>>>
>>>>>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
>>>>>
>>>>>> +	thermal-zones {
>>>>>> +		nct1008-local {
>>>>>> +			polling-delay-passive = <2000>; /* milliseconds */
>>>>>
>>>>> Nothing can possible make use of this node, since there's no compatible
>>>>> value or anything else like that to bind a driver to it.
>>>
>>> We have special Tskin driver that estimator skin temperature based on
>>> nct1008 local and remote sensors.
>>
>> Where? Anything that gets added to the upstream kernel DT files must be
>> supported by a driver and binding in the upstream kernel.
> 
> I didn't submit the Tskin driver yet, but the of-thermal framework can
> parse this node, and create thermal zone devices.

How is that possible? There's no compatible value for the of-thermal
framework to know that it should process this node. It's not correct for
the of-thermal framework to do anything like look for a node with a
particular name... has the DT binding for this been reviewed by any DT
maintainer?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/