linux-kernel - Re: [PATCH 2/3] random: Use arch_get_random_seed*() at init time and once a second

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140305084421.GB2705@gmail.com>
Date:	Wed, 5 Mar 2014 09:44:21 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ted Ts'o <tytso@....edu>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] random: Use arch_get_random_seed*() at init time and
 once a second


* H. Peter Anvin <hpa@...ux.intel.com> wrote:

> From: "H. Peter Anvin" <hpa@...ux.intel.com>
> 
> Use arch_get_random_seed*() in two places in the Linux random
> driver (drivers/char/random.c):
> 
> 1. During entropy pool initialization, use RDSEED in favor of RDRAND,
>    with a fallback to the latter.  Entropy exhaustion is unlikely to
>    happen there on physical hardware as the machine is single-threaded
>    at that point, but could happen in a virtual machine.  In that
>    case, the fallback to RDRAND will still provide more than adequate
>    entropy pool initialization.
> 
> 2. Once a second, issue RDSEED and, if successful, feed it to the
>    entropy pool.  To ensure an extra layer of security, only credit
>    half the entropy just in case.
> 
> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
> ---
>  drivers/char/random.c | 24 ++++++++++++++++++++----
>  1 file changed, 20 insertions(+), 4 deletions(-)

Reviewed-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/