linux-kernel - Re: [PATCH 2/2] ARM: dts: sama5d36ek: add spi pinctrl sleep state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 5 Mar 2014 10:22:11 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Wenyou Yang <wenyou.yang@...el.com>
Cc:	broonie@...nel.org, nicolas.ferre@...el.com, plagnioj@...osoft.com,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@....linux.org.uk, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-spi@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: sama5d36ek: add spi pinctrl sleep state

Hi,

On 05/03/2014 at 09:58:50 +0800, Wenyou Yang wrote :
> Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> ---
>  arch/arm/boot/dts/sama5d36ek.dts |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sama5d36ek.dts b/arch/arm/boot/dts/sama5d36ek.dts
> index 59576c6..676d121 100644
> --- a/arch/arm/boot/dts/sama5d36ek.dts
> +++ b/arch/arm/boot/dts/sama5d36ek.dts
> @@ -18,6 +18,8 @@
>  	ahb {
>  		apb {
>  			spi0: spi@...04000 {
> +				pinctrl-names = "default", "sleep";
> +				pinctrl-1 = <&pinctrl_spi0_sleep>;
>  				status = "okay";
>  			};
>  
> @@ -44,6 +46,18 @@
>  			macb1: ethernet@...2c000 {
>  				status = "okay";
>  			};
> +
> +			pinctrl@...ff200 {
> +				spi0 {
> +					pinctrl_spi0_sleep: spi0-1 {
> +						atmel,pins =
> +							<AT91_PIOD 10 AT91_PERIPH_GPIO AT91_PINCTRL_OUTPUT_LOW	/* PD10 GPIO Output Low */
> +							 AT91_PIOD 11 AT91_PERIPH_GPIO AT91_PINCTRL_OUTPUT_LOW	/* PD11 GPIO Output Low */
> +							 AT91_PIOD 12 AT91_PERIPH_GPIO AT91_PINCTRL_OUTPUT_LOW>;	/* PD12 GPIO Output Low */

I think that one would belong to the dtsi as this is generic enough.

Also, it was suggested by Mark that list entries should be bracketed
separately. But I guess we may not want to mix styles in the same file.
Nicolas, what do you think ?


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/