linux-kernel - RE: [PATCH Resend 2/2] mfd: da9055: Add DT binding documentation for PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2E89032DDAA8B9408CB92943514A03376BAD4D92@SW-EX-MBX01.diasemi.com>
Date:	Wed, 5 Mar 2014 09:50:10 +0000
From:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
To:	Lee Jones <lee.jones@...aro.org>,
	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	"Mark Rutland" <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>
Subject: RE: [PATCH Resend 2/2] mfd: da9055: Add DT binding documentation
 for PMIC

On Tue, 05 Mar 2014 02:40:38 +0000, Lee Jones wrote:

> > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> > Acked-by: Mark Brown <broonie@...nel.org>
> 
> As this has Mark's ack, I'd be happy to apply the patch if you correct
> a couple of nits.

Yep. No problem.

> > +Example:
> > +
> > +	pmic: da9055-pmic@5a {
> > +		compatible = "dlg,da9055-pmic";
> > +		reg = <0x5a>;
> > +		interrupt-parent = <&intc>;
> > +		interrupts = <5 0x8>;
> 
> I'd prefer if you used the #defines in:
>     dt-bindings/interrupt-controller/irq.h

Fine. Will do that.

> > +			buck2: BUCK2 {
> > +				regulator-min-microvolt = <925000>;
> > +				regulator-max-microvolt = <2500000>;
> > +			};
> 
> New line here.

Will remove it.