lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Mar 2014 10:06:03 +0000 From: Will Deacon <will.deacon@....com> To: "John W. Linville" <linville@...driver.com> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>, "pali.rohar@...il.com" <pali.rohar@...il.com>, "pavel@....cz" <pavel@....cz>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] wl1251: use skb_trim to make skb shorter On Tue, Mar 04, 2014 at 06:33:48PM +0000, John W. Linville wrote: > OK, I'll queue it as a fix... Thanks, John. Will > On Tue, Mar 04, 2014 at 02:26:58PM +0000, Will Deacon wrote: > > Hi Jonn, > > > > On Sat, Mar 01, 2014 at 12:52:06PM +0000, Ivaylo Dimitrov wrote: > > > the current code is directly setting skb->len, which is not correct and > > > brings problems with HAVE_EFFICIENT_UNALIGNED_ACCESS enabled in config > > > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com> > > > --- > > > > Can you pick this patch up please? It addresses a regression introduced in > > the merge window (ARM started selecting HAVE_EFFICIENT_UNALIGNED_ACCESS). > > > > Cheers, > > > > Will > > > > > drivers/net/wireless/ti/wl1251/rx.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/wireless/ti/wl1251/rx.c b/drivers/net/wireless/ti/wl1251/rx.c > > > index 123c4bb..cde0eaf 100644 > > > --- a/drivers/net/wireless/ti/wl1251/rx.c > > > +++ b/drivers/net/wireless/ti/wl1251/rx.c > > > @@ -180,7 +180,7 @@ static void wl1251_rx_body(struct wl1251 *wl, > > > wl1251_mem_read(wl, rx_packet_ring_addr, rx_buffer, length); > > > > > > /* The actual length doesn't include the target's alignment */ > > > - skb->len = desc->length - PLCP_HEADER_LENGTH; > > > + skb_trim(skb, desc->length - PLCP_HEADER_LENGTH); > > > > > > fc = (u16 *)skb->data; > > > > > > -- > > > 1.7.9.5 > > > > > > > > > > -- > John W. Linville Someday the world will need a hero, and you > linville@...driver.com might be all we have. Be ready. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists