linux-kernel - Re: [PATCH] clk: turn rate change failed warning into pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140305112828.GN24917@pengutronix.de>
Date:	Wed, 5 Mar 2014 12:28:28 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Mike Turquette <mturquette@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: turn rate change failed warning into pr_debug

Mike,

Any objections to this patch?

Sascha

On Thu, Jan 16, 2014 at 04:12:55PM +0100, Sascha Hauer wrote:
> If a rate change failed it's the opportunity of the caller to handle
> this. Do not spam the log with a message.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Mike Turquette <mturquette@...aro.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/clk/clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 2cf2ea6..f0124d4 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -1460,7 +1460,7 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
>  	/* notify that we are about to change rates */
>  	fail_clk = clk_propagate_rate_change(top, PRE_RATE_CHANGE);
>  	if (fail_clk) {
> -		pr_warn("%s: failed to set %s rate\n", __func__,
> +		pr_debug("%s: failed to set %s rate\n", __func__,
>  				fail_clk->name);
>  		clk_propagate_rate_change(top, ABORT_RATE_CHANGE);
>  		ret = -EBUSY;
> -- 
> 1.8.5.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/