lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Mar 2014 19:42:28 +0800 From: Shawn Guo <shawn.guo@...aro.org> To: Vincent Stehlé <vincent.stehle@...escale.com> CC: Sascha Hauer <kernel@...gutronix.de>, <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Russell King <linux@....linux.org.uk> Subject: Re: [PATCH v2] ARM: dts: imx6qdl-sabresd.dtsi: Add red led On Wed, Mar 05, 2014 at 09:16:23AM +0100, Vincent Stehlé wrote: > Make the red gpio led available to the user. > > This can be toggled with the sysfs for example, or used as a heartbeat or mmc > activity light by changing the trigger. > > Signed-off-by: Vincent Stehlé <vincent.stehle@...escale.com> > Cc: Shawn Guo <shawn.guo@...aro.org> > Cc: Sascha Hauer <kernel@...gutronix.de> > > --- > > Hi Shawn, > > Thanks for your feedback. > > If you don't want to make the led a heartbeat by default, here is v2 of the > patch, which only makes the led available to the user. One is then free to use > it as a heartbeat, or something else. Do you prefer it this way? > > Best regards, > > V. > > > Changes since v1: > - Do not make it a heartbeat by default. > > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > index e75e11b..210a8df 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @@ -88,6 +88,16 @@ > default-brightness-level = <7>; > status = "okay"; > }; > + > + leds { > + compatible = "gpio-leds"; > + > + red { > + gpios = <&gpio1 2 0>; > + linux,default-trigger = "none"; Per Documentation/devicetree/bindings/leds/common.txt, 'none' is not a valid value of property 'linux,default-trigger'. I suggest you simply drop the property. > + default-state = "on"; > + }; > + }; > }; > > &audmux { > @@ -182,6 +192,7 @@ > MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000 > MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x80000000 > MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000 > + MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x80000000 It's not a hog pin, so shouldn't be added here. (Right, most of the existing pins shouldn't be here from the beginning) The patch from Liu Ying [1] could be a good example on this regard. Shawn [1] http://www.spinics.net/lists/arm-kernel/msg308999.html > >; > }; > }; > -- > 1.9.0 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists