| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Mar 2014 20:36:41 +0800 From: Dongsheng Yang <yangds.fnst@...fujitsu.com> To: linux-kernel@...r.kernel.org Cc: fweisbec@...il.com, rostedt@...dmis.org, peterz@...radead.org, mingo@...hat.com, Dongsheng Yang <yangds.fnst@...fujitsu.com> Subject: [PATCH 2/3] sched: Use clamp() and clamp_val() to make it more readable. As Kees suggested, I use clamp() function to replace the if and else branch, making it more readable and modular. Suggested-by: Kees Cook <keescook@...omium.org> Signed-off-by: Dongsheng Yang <yangds.fnst@...fujitsu.com> --- kernel/sched/core.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index ee8004c..5273037 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -3070,17 +3070,10 @@ SYSCALL_DEFINE1(nice, int, increment) * We don't have to worry. Conceptually one call occurs first * and we have a single winner. */ - if (increment < -40) - increment = -40; - if (increment > 40) - increment = 40; - + increment = clamp(increment, -40, 40); nice = task_nice(current) + increment; - if (nice < MIN_NICE) - nice = MIN_NICE; - if (nice > MAX_NICE) - nice = MAX_NICE; + nice = clamp_val(nice, MIN_NICE, MAX_NICE); if (increment < 0 && !can_nice(current, nice)) return -EPERM; -- 1.8.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists