linux-kernel - Re: [PATCH 5/7] staging: cxt1e1: fix checkpatch errors with open brace '{'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHb8M2D8miCPsse4twZxqtSaOAv4bKncUWcm47JXvfKxQZodVw@mail.gmail.com>
Date:	Wed, 5 Mar 2014 09:55:14 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	devel <devel@...verdev.osuosl.org>,
	Shaun Laing <shaun@...source.ca>,
	"sachin.kamat" <sachin.kamat@...aro.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dulshani Gunawardhana <dulshani.gunawardhana89@...il.com>,
	"ying.xue" <ying.xue@...driver.com>,
	David Miller <davem@...emloft.net>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH 5/7] staging: cxt1e1: fix checkpatch errors with open
 brace '{'

Hi, greg

I already resend patch 4 and 5. :-)

It had a bug which is noticed by Dan.

I tried to fix assignment in if condition and missed curly brace in inner loop.
So I fixed that bug and resend patch 4. And patch 5 is rebased after
fixing patch 4.

And I tested to apply these patch to staging-next branch from mailing list.
Please check.

Thanks.
Daeseok Youn.

2014-03-05 9:35 GMT+09:00 Greg KH <gregkh@...uxfoundation.org>:
> On Tue, Mar 04, 2014 at 11:10:44AM +0900, Daeseok Youn wrote:
>>
>> clean up checkpatch.pl error in linux.c:
>>  ERROR: that open brace { should be on the previous line
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
>> ---
>>  drivers/staging/cxt1e1/linux.c |   67 ++++++++++++---------------------------
>>  1 files changed, 21 insertions(+), 46 deletions(-)
>
> As patch 4 can't be applied, I can't apply these either, please resend
> the rest of the series when you fix them up.
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/