linux-kernel - Re: [PATCH v3 2/5] i2c: mv64xxx: Add support for the Allwinner A31 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140305163430.GC9228@katana>
Date:	Wed, 5 Mar 2014 17:34:30 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com,
	kevin.z.m.zh@...il.com, sunny@...winnertech.com,
	shuge@...winnertech.com, zhuzhenhua@...winnertech.com
Subject: Re: [PATCH v3 2/5] i2c: mv64xxx: Add support for the Allwinner A31
 I2C driver

On Tue, Mar 04, 2014 at 05:28:38PM +0100, Maxime Ripard wrote:
> The Allwinner A31 I2C controller is almost identical to the one used in the
> other Allwinner SoCs, except for the fact that it needs to clear the interrupt
> by setting the INT_FLAGS bit in the control register, instead of clearing it.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Reviewed-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>
> Tested-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>

Applied to for-next, thanks!

Still...

> +	if (of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
> +		drv_data->irq_clear_inverted = true;

... next time an errata is needed, I think it makes sense to refactor all
these checks into one struct which can be used as match->data directly.


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)