linux-kernel - Re: [PATCH] kernfs: fix off by one error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877g887eq2.fsf@xmission.com>
Date:	Wed, 05 Mar 2014 09:11:17 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Richard Cochran <richardcochran@...il.com>
Cc:	<linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tejun Heo <tj@...nel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH] kernfs: fix off by one error.

Richard Cochran <richardcochran@...il.com> writes:

> The hash values 0 and 1 are reserved for magic directory entries, but
> the code only prevents names hashing to 0. This patch fixes the test
> to also prevent hash value 1.
>
Reviewed-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> Signed-off-by: Richard Cochran <richardcochran@...il.com>
> Cc: <stable@...r.kernel.org>
> ---
>  fs/kernfs/dir.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
> index bd6e18b..39c0143 100644
> --- a/fs/kernfs/dir.c
> +++ b/fs/kernfs/dir.c
> @@ -37,7 +37,7 @@ static unsigned int kernfs_name_hash(const char *name, const void *ns)
>  	hash = (end_name_hash(hash) ^ hash_ptr((void *)ns, 31));
>  	hash &= 0x7fffffffU;
>  	/* Reserve hash numbers 0, 1 and INT_MAX for magic directory entries */
> -	if (hash < 1)
> +	if (hash < 2)
>  		hash += 2;
>  	if (hash >= INT_MAX)
>  		hash = INT_MAX - 1;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/