linux-kernel - Re: [PATCH] Revert "Bluetooth: Use devname:vhci module alias for virtual HCI driver"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 05 Mar 2014 19:48:39 +0100
From:	Thomas Bächler <thomas@...hlinux.org>
To:	Marcel Holtmann <marcel@...tmann.org>,
	Josh Boyer <jwboyer@...oraproject.org>
CC:	"Gustavo F. Padovan" <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	linux-bluetooth@...r.kernel.org,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "Bluetooth: Use devname:vhci module alias for
 virtual HCI driver"

Am 05.03.2014 19:36, schrieb Marcel Holtmann:
>>>> This reverts commit bfacbb9aec029b3200053d84c8cd5d7575f2d4a5.
>>>
>>> NAK. We allocated a static minor for this.
>>
>> Johan mentioned that.  Commit b075dd40c95d11c2c8690f6c4d6232fc,
>> correct?

I am sorry Marcel, I only looked at the Linus tree, not at bluetooth or
bluetooth-next. This commit should indeed fix the problem. Disregard my
patch.

>  Why isn't that headed into 3.14 right now, and CC'd to
>> stable?  Currently you have a somewhat broken driver in 3.13 and
>> 3.14-rcX that seems to have a pretty clear fix.
> 
> somewhat broken? kmod prints this as an error, but it is not a regression in user functionality. The driver works just as before. The error message can be ignored.

It's a regression in my sanity, since numerous users blame all kernel
bugs on this error message and I am tired of explaining the situation
(problem + error message == problem found *sigh*). I only sent this
patch since I hadn't found the correct fix.

> So if anybody feels strongly that the static device node assignment should be put into -stable, then I am fine with it. However I do not see this as passing requirement for a -stable fix since it is really not affecting anyone (minus the misleading message from kmod).

Since b075dd4 will end up in the Linus tree eventually, I have no
trouble backporting it myself.

Sorry for the disturbance.


Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)