linux-kernel - Re: [PATCH] selftests: ipc: handle msgget failure return correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 05 Mar 2014 18:58:51 +0000
From:	Colin Ian King <colin.king@...onical.com>
To:	Stanislav Kinsbursky <skinsbursky@...allels.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: ipc: handle msgget failure return correctly

On 05/03/14 18:50, Guillaume Morin wrote:
> On 05 Mar 17:51, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> A failed msgget causes the test to return an uninitialised value
>> in ret. Assign ret to -errno on error exit.
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>  tools/testing/selftests/ipc/msgque.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
>> index d664182..be8f294 100644
>> --- a/tools/testing/selftests/ipc/msgque.c
>> +++ b/tools/testing/selftests/ipc/msgque.c
>> @@ -202,6 +202,7 @@ int main(int argc, char **argv)
>>  	msgque.msq_id = msgget(msgque.key, IPC_CREAT | IPC_EXCL | 0666);
>>  	if (msgque.msq_id == -1) {
>>  		printf("Can't create queue\n");
>> +		err = -errno;
>>  		goto err_out;
>>  	}
>>  
>> -- 
> 
> Maybe I am nitpicking here but printf() could modify errno, so you might
> as well save it before printf() is called.
> 
Yep, new patch been sent.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/