linux-kernel - Re: [PATCH] m68k: skip futex_atomic_cmpxchg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdU-5dw9mzJTf-29FAo1NBOnUnqCDv9GPfYRTvuRCS+9Xw@mail.gmail.com>
Date:	Wed, 5 Mar 2014 20:01:39 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Finn Thain <fthain@...egraphics.com.au>
Cc:	Greg Ungerer <gerg@...inux.org>,
	linux-m68k <linux-m68k@...ts.linux-m68k.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k: skip futex_atomic_cmpxchg_inatomic() test

On Tue, Mar 4, 2014 at 8:28 AM, Finn Thain <fthain@...egraphics.com.au> wrote:
> The futex_atomic_cmpxchg_inatomic() test in futex_init() causes a fatal
> exception on 68030 (and presumably 68020 also).

Thanks!

> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> ---
>
> Ingo Molnar has committed Heiko Carstens' patch to the -tip repo:

You mean Thomas Gleixner? ;-)

> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=03b8c7b623c80af264c4c8d6111e5c6289933666
>
> I downloaded that patch and tested it along with the patch below, and
> together these fix the boot crash.
>
> What's the best way to merge this? Perhaps it should be sent on to the
> -tip maintainers?

Yes, please.

And when it's in Linus' tree, we'll have to invoke -stable.

> Index: linux-m68k/arch/m68k/Kconfig
> ===================================================================
> --- linux-m68k.orig/arch/m68k/Kconfig
> +++ linux-m68k/arch/m68k/Kconfig
> @@ -17,6 +17,7 @@ config M68K
>         select FPU if MMU
>         select ARCH_WANT_IPC_PARSE_VERSION
>         select ARCH_USES_GETTIMEOFFSET if MMU && !COLDFIRE
> +       select HAVE_FUTEX_CMPXCHG if MMU && FUTEX
>         select HAVE_MOD_ARCH_SPECIFIC
>         select MODULES_USE_ELF_REL
>         select MODULES_USE_ELF_RELA

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/