linux-kernel - Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394056859.12070.23.camel@joe-AO722>
Date:	Wed, 05 Mar 2014 14:00:59 -0800
From:	Joe Perches <joe@...ches.com>
To:	Shuah Khan <shuah.kh@...sung.com>
Cc:	lgirdwood@...il.com, broonie@...nel.org,
	gregkh@...uxfoundation.org, stable@...r.kernel.org,
	linux-kernel@...r.kernel.org, shuahkhan@...il.com,
	Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH 3.13] regulator: core: Change dummy supplies error
 message to a warning

On Wed, 2014-03-05 at 14:29 -0700, Shuah Khan wrote:
> Change "dummy supplies not allowed" error message to warning instead,
> as this is a just warning message with no change to the behavior.
[]
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
[]
> @@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
>  		rdev = dummy_regulator_rdev;
>  		goto found;
>  	} else {
> -		dev_err(dev, "dummy supplies not allowed\n");
> +		dev_warn(dev, "dummy supplies not allowed\n");

What does this mean anyway?

Would it be better to emit the calling function too with
%pf, __builtin_return_address(0)?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/