lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140305221047.GC18529@joshc.qualcomm.com> Date: Wed, 5 Mar 2014 16:10:47 -0600 From: Josh Cartwright <joshc@...eaurora.org> To: Rob Herring <robherring2@...il.com> Cc: Georgi Djakov <gdjakov@...sol.com>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, Chris Ball <cjb@...top.org>, Ulf Hansson <ulf.hansson@...aro.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Stephen Warren <swarren@...dotorg.org>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Rob Landley <rob@...dley.net>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-arm-msm <linux-arm-msm@...r.kernel.org> Subject: Re: [PATCH v10 1/3] mmc: sdhci-msm: Qualcomm SDHCI binding documentation Hey Rob- On Wed, Mar 05, 2014 at 12:56:22AM -0600, Rob Herring wrote: > On Tue, Mar 4, 2014 at 1:27 PM, Georgi Djakov <gdjakov@...sol.com> wrote: > > +- reg-names: Should contain the following: > > + "hc_mem" - Host controller register map > > + "core_mem" - SD Core register map > > reg-names should not be required and the order specified by the binding. > > > +- interrupts: Should contain an interrupt-specifiers for the interrupts listed in interrupt-names. > > +- interrupt-names: Should contain the following: > > + "hc_irq" - Host controller interrupt > > + "pwr_irq" - PMIC interrupt > > Same for interrupt-names. Could you elaborate on this a bit? I can understand not modifying an existing binding to make {reg,interrupt}-names required, but for completely new bindings, why is this a problem? Not allowing a binding to require these properties renders platform_get_{resource,irq}_byname() useless for drivers which exclusively use DT for enumeration. It also makes it impossible to make a reg entry optional (although, there probably isn't a good usecase for this). Thanks, Josh -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists